countify/countify
2
1
Fork 0
Code Issues 10 Pull requests 7 Projects 3 Releases Packages 1 Wiki Activity Actions

implement /hit API endpoint #18

Merged
Firepup650 merged 9 commits from hit-endpoint into main 2024-05-25 04:53:34 +00:00
Conversation 0 Commits 9 Files changed 1 +49
9pfs commented 2024-05-25 00:43:36 +00:00
Owner
Copy link

Closes #6

Closes #6
9pfs added the
Kind/Feature
 label 2024-05-25 00:43:36 +00:00
9pfs added 1 commit 2024-05-25 00:43:37 +00:00
Partially implement /hit
All checks were successful
Run node --check on everything / node-check (push) Successful in 8s
Details
Make sure the server is actually able to start / prettier (push) Successful in 26s
Details
Check project using prettier / prettier (push) Successful in 34s
Details
Run node --check on everything / node-check (pull_request) Successful in 6s
Details
Make sure the server is actually able to start / prettier (pull_request) Successful in 22s
Details
Check project using prettier / prettier (pull_request) Successful in 21s
Details
361ab5e8f4
Firepup650 added 1 commit 2024-05-25 00:55:23 +00:00
Fixes to the /hit endpoint
Some checks failed
Run node --check on everything / node-check (push) Successful in 9s
Details
Run node --check on everything / node-check (pull_request) Successful in 10s
Details
Check project using prettier / prettier (push) Failing after 25s
Details
Check project using prettier / prettier (pull_request) Failing after 28s
Details
Make sure the server is actually able to start / prettier (pull_request) Successful in 32s
Details
Make sure the server is actually able to start / prettier (push) Successful in 42s
Details
37177e391d
9pfs added 1 commit 2024-05-25 00:58:24 +00:00
run prettier
All checks were successful
Run node --check on everything / node-check (push) Successful in 6s
Details
Run node --check on everything / node-check (pull_request) Successful in 8s
Details
Make sure the server is actually able to start / prettier (push) Successful in 30s
Details
Make sure the server is actually able to start / prettier (pull_request) Successful in 27s
Details
Check project using prettier / prettier (pull_request) Successful in 32s
Details
Check project using prettier / prettier (push) Successful in 38s
Details
1906580fb4
9pfs added 1 commit 2024-05-25 01:07:18 +00:00
Merge branch 'main' into hit-endpoint
All checks were successful
Run node --check on everything / node-check (push) Successful in 6s
Details
Run node --check on everything / node-check (pull_request) Successful in 9s
Details
Make sure the server is actually able to start / prettier (push) Successful in 24s
Details
Make sure the server is actually able to start / prettier (pull_request) Successful in 27s
Details
Check project using prettier / prettier (pull_request) Successful in 24s
Details
Check project using prettier / prettier (push) Successful in 31s
Details
146e05751d
9pfs added 1 commit 2024-05-25 01:20:21 +00:00
Merge branch 'main' into hit-endpoint
All checks were successful
Run node --check on everything / node-check (pull_request) Successful in 7s
Details
Make sure the server is actually able to start / prettier (pull_request) Successful in 24s
Details
Check project using prettier / prettier (pull_request) Successful in 32s
Details
2c42cf9dc8
Firepup650 added 1 commit 2024-05-25 01:53:47 +00:00
Hit is supposed to make keys, following the countapi spec.
Some checks failed
Run node --check on everything / node-check (pull_request) Successful in 8s
Details
Make sure the server is actually able to start / prettier (pull_request) Successful in 22s
Details
Check project using prettier / prettier (pull_request) Failing after 21s
Details
6de8f5bcdb
Firepup650 added 1 commit 2024-05-25 01:55:26 +00:00
Run prettier
All checks were successful
Run node --check on everything / node-check (pull_request) Successful in 6s
Details
Make sure the server is actually able to start / prettier (pull_request) Successful in 26s
Details
Check project using prettier / prettier (pull_request) Successful in 31s
Details
aaed9e854d
9pfs added 1 commit 2024-05-25 04:16:26 +00:00
Merge branch 'main' into hit-endpoint
All checks were successful
Run node --check on everything / node-check (pull_request) Successful in 8s
Details
Check project using prettier / prettier (pull_request) Successful in 21s
Details
Make sure the server is actually able to start / boot-test (pull_request) Successful in 27s
Details
6dfb8ce705
9pfs changed title from WIP: implement /hit API endpoint to implement /hit API endpoint 2024-05-25 04:29:37 +00:00
9pfs requested review from Firepup650 2024-05-25 04:32:03 +00:00
9pfs added 1 commit 2024-05-25 04:45:28 +00:00
Handle requests with no namespace correctly
All checks were successful
Run node --check on everything / node-check (pull_request) Successful in 7s
Details
Check project using prettier / prettier (pull_request) Successful in 20s
Details
Make sure the server is actually able to start / boot-test (pull_request) Successful in 34s
Details
7151c77d15
Firepup650 approved these changes 2024-05-25 04:52:14 +00:00
Firepup650 left a comment
Owner
Copy link
23:46:55 <@firepup-lounge> https://www.rfc-editor.org/rfc/rfc9110#section-15.5.4-2
23:46:55 <@firepup-lounge> 403 is really about auth creds IMO
23:48:36 <@firepup-lounge> I'd rather 412 or 422 over it
23:48:40 <@firepup-lounge> (in that order)
23:49:11 <@firepup-lounge> 412 - https://www.rfc-editor.org/rfc/rfc9110#section-15.5.13-1
23:49:11 <@firepup-lounge> 422 - https://www.rfc-editor.org/rfc/rfc9110#section-15.5.21-1
23:49:25 <@firepup-lounge> I think the most correct by the RFC would be 422
23:49:41 <@firepup-lounge> > The 422 (Unprocessable Content) status code indicates that the server understands the content type of the request content (hence a 415 (Unsupported Media Type) status code is inappropriate), and the syntax of the request content is correct, but it was unable to process the contained instructions. 
23:51:34 <@firepup-lounge> I'll approve for now, but I'm totally making my next PR be to change from 403 to 422
``` 23:46:55 <@firepup-lounge> https://www.rfc-editor.org/rfc/rfc9110#section-15.5.4-2 23:46:55 <@firepup-lounge> 403 is really about auth creds IMO 23:48:36 <@firepup-lounge> I'd rather 412 or 422 over it 23:48:40 <@firepup-lounge> (in that order) 23:49:11 <@firepup-lounge> 412 - https://www.rfc-editor.org/rfc/rfc9110#section-15.5.13-1 23:49:11 <@firepup-lounge> 422 - https://www.rfc-editor.org/rfc/rfc9110#section-15.5.21-1 23:49:25 <@firepup-lounge> I think the most correct by the RFC would be 422 23:49:41 <@firepup-lounge> > The 422 (Unprocessable Content) status code indicates that the server understands the content type of the request content (hence a 415 (Unsupported Media Type) status code is inappropriate), and the syntax of the request content is correct, but it was unable to process the contained instructions. 23:51:34 <@firepup-lounge> I'll approve for now, but I'm totally making my next PR be to change from 403 to 422 ```
Firepup650 merged commit 64affde372 into main 2024-05-25 04:53:34 +00:00
Firepup650 deleted branch hit-endpoint 2024-05-25 04:53:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Firepup650
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: countify/countify#18
No description provided.
Delete branch "hit-endpoint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?