9pfs/solanum-vs-hackint-and-charybdis
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ircd: sendto_one_numeric: avoid clang static analysis warning

Browse source 
target_p->from can't be NULL, and if it is then get_id(..., target_p)
dereferences it later in the function anyway
This commit is contained in:
Simon Arlott 2017-07-29 20:16:59 +01:00
parent 4a9f4dccb8
commit 0d6da1a9c1
No known key found for this signature in database
GPG key ID: C8975F2043CA5D24
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ircd/send.c
View file

@ -387,17 +387,11 @@ sendto_one_notice(struct Client *target_p, const char *pattern, ...)
void void
sendto_one_numeric(struct Client *target_p, int numeric, const char *pattern, ...) sendto_one_numeric(struct Client *target_p, int numeric, const char *pattern, ...)
{ {
struct Client *dest_p; struct Client *dest_p = target_p->from;
va_list args; va_list args;
buf_head_t linebuf; buf_head_t linebuf;
char *to; char *to;
/* send remote if to->from non NULL */
if(target_p->from != NULL)
dest_p = target_p->from;
else
dest_p = target_p;
if(IsIOError(dest_p)) if(IsIOError(dest_p))
return; return;