9pfs/solanum-vs-hackint-and-charybdis
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

timeout_dead_authd_clients(): fix memory leak and order of operations (#385)

Browse source 
Ensure we deallocate the nodes created by the first loop, and zero out
the authd data after removing them from the authd clients dict.

The authd_abort_client() function already does the latter, so just call
that instead of authd_free_client().
This commit is contained in:
Aaron Jones 2022-11-06 08:14:15 +00:00 committed by GitHub
parent ed775e9bb4
commit 63ee10379c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ircd/authproc.c
View file

@ -566,7 +566,6 @@ timeout_dead_authd_clients(void *notused __unused)
{ {
if(client_p->preClient->auth.timeout < rb_current_time()) if(client_p->preClient->auth.timeout < rb_current_time())
{ {
authd_free_client(client_p);
rb_dlinkAddAlloc(client_p, &freelist); rb_dlinkAddAlloc(client_p, &freelist);
} }
} }
@ -575,7 +574,8 @@ timeout_dead_authd_clients(void *notused __unused)
RB_DLINK_FOREACH_SAFE(ptr, nptr, freelist.head) RB_DLINK_FOREACH_SAFE(ptr, nptr, freelist.head)
{ {
client_p = ptr->data; client_p = ptr->data;
rb_dictionary_delete(cid_clients, RB_UINT_TO_POINTER(client_p->preClient->auth.cid)); authd_abort_client(client_p);
rb_dlinkDestroy(ptr, &freelist);
} }
} }