9pfs/solanum-vs-hackint-and-charybdis
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

whois: check target is an oper before assuming they have a privset

Browse source 
The CHALLENGE functionality will set opername but not privset --
if an oper performs a WHOIS on someone currently half-way through
a challenge we will perform a NULL dereference.

Related to ircd-seven commit d7b05f7583babf6
This commit is contained in:
Aaron Jones 2016-09-20 13:45:22 +00:00
parent 5de892828f
commit 866026ab70
No known key found for this signature in database
GPG key ID: EC6F86EE9CD840B5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/m_whois.c
View file

@ -326,7 +326,7 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
GlobalSetOptions.operstring)); GlobalSetOptions.operstring));
} }
if(MyClient(target_p) && !EmptyString(target_p->localClient->opername) && IsOper(source_p)) if(MyClient(target_p) && !EmptyString(target_p->localClient->opername) && IsOper(target_p) && IsOper(source_p))
{ {
char buf[512]; char buf[512];
rb_snprintf(buf, sizeof(buf), "is opered as %s, privset %s", rb_snprintf(buf, sizeof(buf), "is opered as %s, privset %s",