9pfs/solanum-vs-hackint-and-charybdis
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix buffer overflow in introduce_client and burst_TS6

Browse source 
If the client being introduced has more than 10 user modes send_umode()
will overflow ubuf
This commit is contained in:
Adam 2014-05-13 19:21:27 -04:00
parent ad4b76b417
commit 9744d53ec9
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/s_serv.c
View file

@ -555,7 +555,7 @@ burst_modes_TS6(struct Client *client_p, struct Channel *chptr,
static void static void
burst_TS6(struct Client *client_p) burst_TS6(struct Client *client_p)
{ {
static char ubuf[12]; char ubuf[BUFSIZE];
struct Client *target_p; struct Client *target_p;
struct Channel *chptr; struct Channel *chptr;
struct membership *msptr; struct membership *msptr;

2
src/s_user.c
View file

@ -592,7 +592,7 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
int int
introduce_client(struct Client *client_p, struct Client *source_p, struct User *user, const char *nick, int use_euid) introduce_client(struct Client *client_p, struct Client *source_p, struct User *user, const char *nick, int use_euid)
{ {
static char ubuf[12]; char ubuf[BUFSIZE];
struct Client *identifyservice_p; struct Client *identifyservice_p;
char *p; char *p;
hook_data_umode_changed hdata; hook_data_umode_changed hdata;