9pfs/solanum-vs-hackint-and-charybdis
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

read/write return type should be ssize_t, not int or size_t.

Browse source 
The writev emulation used size_t, which is unsigned,
preventing negative values to be seen.
libratbox r25225
This commit is contained in:
Jilles Tjoelker 2008-04-12 16:43:12 +02:00
parent 5fbc8344c9
commit ba1721d144
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
libratbox/src/commio.c
View file

@ -950,7 +950,7 @@ rb_get_fde(int fd)
ssize_t ssize_t
rb_read(rb_fde_t *F, void *buf, int count) rb_read(rb_fde_t *F, void *buf, int count)
{ {
int ret; ssize_t ret;
if(F == NULL) if(F == NULL)
return 0; return 0;
@ -982,7 +982,7 @@ rb_read(rb_fde_t *F, void *buf, int count)
ssize_t ssize_t
rb_write(rb_fde_t *F, const void *buf, int count) rb_write(rb_fde_t *F, const void *buf, int count)
{ {
int ret; ssize_t ret;
if(F == NULL) if(F == NULL)
return 0; return 0;
@ -1008,11 +1008,11 @@ rb_write(rb_fde_t *F, const void *buf, int count)
static ssize_t static ssize_t
rb_fake_writev(rb_fde_t *F, const struct rb_iovec *vp, size_t vpcount) rb_fake_writev(rb_fde_t *F, const struct rb_iovec *vp, size_t vpcount)
{ {
size_t count = 0; ssize_t count = 0;
while (vpcount-- > 0) while (vpcount-- > 0)
{ {
size_t written = rb_write(F, vp->iov_base, vp->iov_len); ssize_t written = rb_write(F, vp->iov_base, vp->iov_len);
if (written <= 0) if (written <= 0)
{ {