From c8641a273f957e9f41b030f6696fd8d6cb2780ca Mon Sep 17 00:00:00 2001 From: Simon Arlott Date: Sun, 30 Oct 2016 11:21:02 +0000 Subject: [PATCH] free localClient->cipher_string, allocated in sslproc.c ==01:17:20:36.919 5966== 280 bytes in 8 blocks are definitely lost in loss record 876 of 1,020 ==01:17:20:36.919 5966== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==01:17:20:36.919 5966== by 0x4E93F4F: rb_strdup (rb_memory.h:70) ==01:17:20:36.919 5966== by 0x4E95280: ssl_process_cipher_string (sslproc.c:476) ==01:17:20:36.919 5966== by 0x4E95540: ssl_process_cmd_recv (sslproc.c:561) ==01:17:20:36.919 5966== by 0x4E9582A: ssl_read_ctl (sslproc.c:632) ==01:17:20:36.919 5966== by 0x56CBAB6: rb_select_epoll (epoll.c:199) ==01:17:20:36.919 5966== by 0x56C4EB5: rb_select (commio.c:2085) ==01:17:20:36.919 5966== by 0x56C7FD6: rb_lib_loop (rb_lib.c:228) ==01:17:20:36.919 5966== by 0x4E69987: charybdis_main (ircd.c:872) ==01:17:20:36.919 5966== by 0x400815: main (main.c:8) --- ircd/client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ircd/client.c b/ircd/client.c index 8c78145e..87f0b3b8 100644 --- a/ircd/client.c +++ b/ircd/client.c @@ -314,6 +314,8 @@ free_local_client(struct Client *client_p) if (IsSSL(client_p)) ssld_decrement_clicount(client_p->localClient->ssl_ctl); + rb_free(client_p->localClient->cipher_string); + if (IsCapable(client_p, CAP_ZIP)) ssld_decrement_clicount(client_p->localClient->z_ctl);