9pfs/solanum-vs-hackint-and-charybdis
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ircd: substitution: fix NULL termination buffer overrun when the output is too large for the buffer

Browse source
This commit is contained in:
Simon Arlott 2017-07-27 12:58:23 +01:00
parent 1dfb080874
commit fb81421fc7
No known key found for this signature in database
GPG key ID: C8975F2043CA5D24
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ircd/substitution.c
View file

@ -140,8 +140,11 @@ char *substitution_parse(const char *fmt, rb_dlink_list *varlist)
if (!rb_strcasecmp(varname, val->name)) if (!rb_strcasecmp(varname, val->name))
{ {
rb_strlcpy(bptr, val->value, BUFSIZE - (bptr - buf)); rb_strlcpy(bptr, val->value, sizeof(buf) - (bptr - buf));
bptr += strlen(val->value); bptr += strlen(val->value);
if (bptr >= &buf[sizeof(buf)]) {
bptr = &buf[sizeof(buf) - 1];
}
break; break;
} }
} }