Adam
9744d53ec9
Fix buffer overflow in introduce_client and burst_TS6
...
If the client being introduced has more than 10 user modes send_umode()
will overflow ubuf
2014-05-13 19:33:41 -04:00
Mantas Mikulėnas
ad4b76b417
help: Update indexes
...
`make index` (add PRIVS for opers, CHANTRACE for users)
2014-05-10 15:10:36 +03:00
Mantas Mikulėnas
457f6802e0
help: Add MONITOR to the user symlinks
...
Apparently the overrides are done at `make install` time, okay.
2014-05-10 15:04:29 +03:00
Mantas Mikulėnas
c72f15bcf5
m_version: remove spaces from version string
...
"to make it machine parseable again", as in ircd-seven commit 03b2176b88a1.
2014-05-06 16:28:23 +03:00
Mantas Mikulėnas
0f4ed4058d
m_version: display charybdis version in /version
...
Otherwise it just crashes when /version is used.
Closes : #60
2014-05-06 16:27:03 +03:00
Jilles Tjoelker
bf77c3a1ef
info: Change N-line to connect block.
2014-04-27 15:33:09 +02:00
auscompgeek
bd96349c86
strip_colour: Strip '\x0F' (^O, formatting off)
...
Reported by ssbr on freenode:
chmode +c doesn't strip ^O, which turns off all previous formatting.
This can cause clients that internally use mIRC formatting to render messages weirdly,
e.g. highlighted messages in HexChat: <https://i.imgur.com/eDX8Aif.png >.
2014-04-17 13:12:11 +10:00
Jilles Tjoelker
a0998bcdd7
example confs: Remove AHBL blacklists, which are no longer available.
2014-04-06 12:34:03 +02:00
Alex Iadicicco
011e38be79
mkpasswd: Prompt for password twice
2014-04-04 16:46:44 -07:00
Douglas Freed
cea0689e80
Fix const qualifier on raw_mask
...
Fixes compilation warning about losing const qualifier in assignment to
non-const variable
(cherry picked from commit 6d9c3f50944e1da3bf3a1be6454f85d6d6f7ab37)
2014-03-09 19:13:25 +01:00
Jilles Tjoelker
0c5e50f430
Fix format string type mismatch in src/capability.c.
...
The type 'long' was correct on most machines but not according to the C
standard and Windows 64-bit.
2014-03-09 19:11:54 +01:00
Jilles Tjoelker
e3cb855407
Restore trailing whitespace in sqlite3 amalgamation.
...
Stripping the whitespace from the upstream-maintained sqlite3 code just
causes merge conflicts with no benefit.
2014-03-09 17:54:26 +01:00
Jilles Tjoelker
5457b10278
Fix fd leak if /dev/urandom can be opened but not read.
2014-03-09 14:54:45 +01:00
Jilles Tjoelker
72cc5a995f
Add first cut at 3.5.0 NEWS. [ci skip]
2014-03-07 23:07:02 +01:00
Jilles Tjoelker
0894d18b87
blacklist: Make the snote more like the +c one.
2014-03-07 21:55:43 +01:00
William Pitcock
9e7c930672
Merge pull request #53 from ShadowNinja/clarify_U+R
...
Clarify UMODE +R help text
2014-03-06 09:59:37 -06:00
Keith Buck
48e409767f
Add DNSBL snotes for snomask +r.
2014-03-05 08:12:22 +00:00
Jilles Tjoelker
0455e7a927
Remove snotes on +r about GET/PUT/POST commands.
...
The server notice "HTTP Proxy disconnected: [<user>@<host>]" is
confusing and not particularly useful.
2014-03-04 23:02:40 +01:00
Keith Buck
55abcbb20a
Remove trailing whitespace from all .c and .h files.
...
3134 bytes were removed.
2014-03-03 04:25:47 +00:00
Keith Buck
00533129dc
s_conf: Don't leak log file paths when loading default conf
...
This change prevents the log file paths from being leaked when
rehashing. Additionally, fname_killlog was added to two places where it
was previously forgotten.
2014-03-03 04:12:07 +00:00
Keith Buck
010c4fbdc5
s_conf: Don't leak strings when loading default conf
...
This change prevents conf strings from being leaked when resetting the
conf to default prior to a rehash. Additionally, some default strings
are now rb_strdup'd into the ConfigFileEntry structure after loading the
conf so that they aren't allocated and then immediately freed by the
conf loading process.
2014-03-03 03:58:40 +00:00
Keith Buck
9e26f0008b
libratbox openssl: Don't leak EC_KEY structures.
2014-03-03 01:43:33 +00:00
Keith Buck
023c36ae22
newconf.c: Remove end-of-line whitespace.
2014-03-03 01:43:33 +00:00
Keith Buck
e12981c028
conf parsing: Fix freeing section names upon section end.
2014-03-03 01:43:33 +00:00
Jilles Tjoelker
fea6157df0
Avoid possible null dereference.
2014-03-03 00:02:10 +01:00
Keith Buck
1d39324556
Fix a couple more string leaks.
2014-03-02 22:05:30 +00:00
Jilles Tjoelker
ee2d4c2d9d
commio: Properly zero a struct msghdr.
...
This bug is probably not noticeable because all specified fields are
initialized later.
2014-03-02 22:12:19 +01:00
Jilles Tjoelker
e053adc87e
commio: Explicitly ignore return value from setsockopt(TCP_DEFER_ACCEPT).
2014-03-02 22:09:08 +01:00
Jilles Tjoelker
f1709d5ac8
sslproc: Add missing break, still allowing zlib when ssl cannot be set up.
2014-03-02 21:58:38 +01:00
Jilles Tjoelker
0e717d8eb4
log_client_name: Remove MASK_IP case.
...
The MASK_IP case in log_client_name() was broken (because of a missing
break, it behaved as HIDE_IP). However, log_client_name() with MASK_IP
does not make sense anyway and is not used.
2014-03-02 21:54:29 +01:00
Jilles Tjoelker
b222b6a05a
findforwards: Don't compare array to NULL as this is always true.
2014-03-02 21:47:36 +01:00
Jilles Tjoelker
40173bcbb3
listener: Move error messages to something visible by default.
...
If a listening port cannot be opened, send error messages to opers with
snomask +s and ircd.log, instead of snomask +d and the ioerror log, which
both are usually disabled.
Also, restore information about what listener is having problems. This
was lost when report_error() was replaced.
2014-03-01 19:05:55 +01:00
Jilles Tjoelker
4229cef34c
doc/extban: Correct description of EXTBAN token in 005.
...
The change from EXTBAN=$:<types> to EXTBAN=$,<types> was made later on
and the documentation was not adjusted.
2014-03-01 18:16:40 +01:00
Keith Buck
dceac3e4fb
conf parsing: Fix memory leaks and clean up code a bit.
...
Charybdis currently leaks about 45-50k per configuration parse,
including every rehash. This change plugs these leaks by properly
iterating through all conf_parm_t structures to seek all strings that
should be freed and also by freeing the conf_parm_t structures
themselves.
These leaks have been present since the original rewrite of the
configuration parsing system in ircd-ratbox r11953.
Additionally, this change also cleans up and documents the parsing code
a bit.
2014-02-28 17:35:51 +00:00
Jilles Tjoelker
e8cfec47c6
ircd_parser: Fix whitespace errors.
2014-02-28 15:51:52 +01:00
Jilles Tjoelker
299e25a630
SIGNON: Do not send uninitialized data if login name starts with '*'.
2014-02-28 15:48:07 +01:00
Jilles Tjoelker
6993ae2760
libratbox: Abort if the restart callback returns.
2014-02-28 00:53:13 +01:00
Jilles Tjoelker
f76ca17848
stats c: Simplify construction of flags string.
...
Perhaps this avoids false positives in static analysis.
2014-02-24 00:10:42 +01:00
Jilles Tjoelker
3cbcc11195
commio: Add error string for SSL trouble.
2014-02-24 00:06:19 +01:00
Jilles Tjoelker
a1f7ec5be0
server: Use rb_strlcpy() instead of strcpy().
...
An overflow should be impossible here, but be paranoid.
2014-02-24 00:04:11 +01:00
Jilles Tjoelker
26c6ac3dc7
Simplify module path list, removing strcpy use.
2014-02-23 23:47:27 +01:00
Jilles Tjoelker
b84e58f905
Fix use after free.
2014-02-23 23:46:57 +01:00
Jilles Tjoelker
12edf3e3d2
conf: Remove dead store.
2014-02-23 23:04:52 +01:00
Jilles Tjoelker
77910830e3
Fix various printf arg types.
2014-02-23 23:01:59 +01:00
Jilles Tjoelker
29c451d0ce
part: Fix constness issue with part hook.
2014-02-23 23:01:59 +01:00
Jilles Tjoelker
a9f1281448
modlist: Fix address display on 64-bit systems.
2014-02-23 22:55:40 +01:00
Jilles Tjoelker
1e170010e7
modules: Fix bad sizeofs.
2014-02-23 22:39:42 +01:00
Jilles Tjoelker
5ef68b1398
Replace double semicolons with single; place null statement on its own line.
...
No functional change is intended.
2014-02-23 22:23:34 +01:00
Jilles Tjoelker
43f45e81fb
conf: Do not leak memory when modules::module is already loaded.
2014-02-23 22:20:43 +01:00
Jilles Tjoelker
f9960c0262
extensions/mkpasswd: Do not leak /dev/random fd.
2014-02-23 22:18:44 +01:00
