Commit graph

173 commits

Author SHA1 Message Date
Aaron Jones
c67c9451a1
extensions/hurt.c: misc cleanups for compiler warnings
hurt.c:196:16: warning: possible misuse of comma operator here [-Wcomma]

    (... and 3 more of the same)
2017-08-04 12:32:57 +00:00
Aaron Jones
daf1b4b9af
extensions/m_sendbans.c: misc cleanup for compiler warning
m_sendbans.c:76:15: warning: possible misuse of comma operator here
                    [-Wcomma]
2017-08-04 12:32:57 +00:00
Simon Arlott
9d7c65294f
m_webirc: set sockhost before potentially using it to set host
Remove extra IP check, it's not necessary.
2017-08-01 22:50:30 +01:00
Simon Arlott
51d65d191a
m_webirc: use rb_inet_ntop_sock to populate sockhost 2017-06-27 21:15:14 +01:00
Ellenor Malik
e0f1c3b5bc
extensions/extb_ssl.c: add support for matching by certificate fingerprint 2017-06-16 01:51:38 +00:00
Keith Buck
4574e77f43 extensions/extb_channel: Allow matching secret channels.
This change modifies extb_channel to allow matching users in secret
channels, which prevents trivial ban evasion by setting the target
channel +s. Information leak due to this change is unlikely since the
attacker would have to know that the target channel exists, the name of
the channel (or guess it), have a specific user they wanted to know
whether was in the channel (and not know already), and the target user
would need to have something like autojoin-on-invite enabled (or any of
the other various ways hostname cloaking is attacked).
2016-12-29 05:44:18 +00:00
Aaron Jones
e5afd80775
mkpasswd: use urandom for salts, cleanup
Using /dev/random for salt generation is pointless -- it can block, and
any extra randomness it would provide (which is debatable) is not needed,
as salts only need to be unique, not unpredictable.
2016-08-15 09:49:57 +00:00
Aaron Jones
604ab13778
extensions: Fix duplicate extban character usage
extb_usermode and extb_hostmask both use the same extban character
('m'), resulting in only one of the modules being usable (depending
on module load order) and neither one functioning if one of them
is unloaded.

This changes the character for extb_usermode from 'm' to 'u'.

[ci skip]
2016-03-28 03:33:24 +01:00
William Pitcock
947d2bba47 extb_oper: allow matching $o:<privset> as well as $o:<permission> as in 3.4 2016-01-05 19:12:38 -06:00
William Pitcock
32d5702869 extensions: add the ability to hide uncommon channels in WHOIS, like in ircd-seven (closes #6) 2016-01-05 18:45:07 -06:00
William Pitcock
340b2512d4 sno_whois: fix resource leak, pointed out by mniip 2015-12-27 17:08:57 -06:00
William Pitcock
a2bc8af8c5 extb_combi: relax recursion and complexity limits now that bancache for unjoined users is fixed 2015-12-13 11:38:27 -06:00
William Pitcock
2749c37c43 extb_combi: tighten up recursion depth 2015-12-13 11:22:47 -06:00
William Pitcock
9145dc0956 extb_combi: allow up to 5 children nodes 2015-12-13 11:09:15 -06:00
William Pitcock
5984986bcf extb_combi: if there are more nodes than allowed, return EXTBAN_INVALID 2015-12-13 11:06:04 -06:00
William Pitcock
2e548a8a04 extb_combi: try limiting the number of allowed nodes per depth to 3 2015-12-13 10:58:05 -06:00
William Pitcock
d63f3f80f0 extb_combi: implement a recursion guard 2015-12-13 07:50:02 -06:00
Jilles Tjoelker
2d28539c68 Reduce clean_nick() code duplication further.
Side effect: hurt and monitor now allow nicks starting with a digit.
2015-12-13 00:22:21 +01:00
William Pitcock
72dee03d50 clean up some code duplication when checking nicks for validity 2015-12-12 08:41:09 -06:00
William Pitcock
e2a9fa9cab extenions: add a $m: extban (ref #74) 2015-12-10 02:25:22 -06:00
William Pitcock
4ef511ebb8 import marienz's extb_combi module (ref #74) 2015-12-10 02:20:58 -06:00
William Pitcock
202d496644 override: only engage override code if we're needing to authorize a WRITE to a channel's state (closes #65) 2015-12-10 01:00:32 -06:00
Jail Bird
29c92cf95f Spring cleaning redux:
- Implemented changes suggested by Jilles
- Remove some unused parameters in functions
- Remove some unused ssl procs
- 63-bit time_t support in TS deltas
- const char * vs char * cleanup
- struct alignment (void *) casts
- signed vs unsigned fixes
- bad memset() call
- Bad LT_MAIN in libratbox
- char -> unsigned char casts for isdigit/isspace/etc calls

Thanks Jilles!
2015-04-20 00:55:20 -05:00
Jilles Tjoelker
3bfac098f7 extensions/extb_channel: Allow the channel itself as target even if +s/+p. 2014-07-19 20:14:14 +02:00
Jilles Tjoelker
83aa910fb9 extensions/chm_sslonly: Use some 4xx numeric for the join failure. 2014-07-19 20:14:14 +02:00
Keith Buck
55abcbb20a Remove trailing whitespace from all .c and .h files.
3134 bytes were removed.
2014-03-03 04:25:47 +00:00
Jilles Tjoelker
b222b6a05a findforwards: Don't compare array to NULL as this is always true. 2014-03-02 21:47:36 +01:00
Jilles Tjoelker
f9960c0262 extensions/mkpasswd: Do not leak /dev/random fd. 2014-02-23 22:18:44 +01:00
Jilles Tjoelker
a6b29d3ed4 extensions/roleplay: Fix memory leak on every use. 2014-02-23 22:01:04 +01:00
Jilles Tjoelker
0391874cc7 webirc: Check validity of given IP. 2014-02-23 21:14:09 +01:00
Andrew
46b55df60b Fix grammatical error 2013-12-12 04:08:12 +00:00
Jilles Tjoelker
e5c254d7d1 override: Remove umode +p when deopering. 2013-10-25 17:49:58 +02:00
Keith Buck
0137d36122 Revert "Add m_override.c - an improved override module."
This reverts commit f00a55e9a1.
2013-10-25 05:39:55 +00:00
Keith Buck
f00a55e9a1 Add m_override.c - an improved override module. 2013-10-24 06:36:22 +00:00
Keith Buck
77d3d2dbaf Remove s_assert definition from ircd_defs.h and add it to its own header.
s_assert requires some higher-level functionality that shouldn't be
present in ircd_defs.h. ircd_defs.h is used by ssld, which has no notion
of logging or sending IRC messages. Additionally, some of the headers
s_assert depends on result in conflicting definitions in ssld.c.

This change also fixes the compile when using --enable-assert=soft.
2013-09-10 06:10:14 +00:00
Alex Iadicicco
e03fc000a2 extensions/m_roleplay: Properly transmit source name. 2013-08-23 20:11:22 -07:00
Jilles Tjoelker
0ef5377a36 Rename m_nokillservices.so to no_kill_services.so per the naming scheme. 2013-04-27 17:00:10 +02:00
Jilles Tjoelker
ee45698302 nokillservices: Use ircu numeric instead of a notice. 2013-04-27 16:55:26 +02:00
Elizabeth Myers
4f253f11a2 Forgot this -.- 2013-04-27 05:07:04 -05:00
Elizabeth Myers
06c3a3191c Fix minor comment munging from sed being a piece of shit 2013-04-27 04:59:57 -05:00
Elizabeth Myers
bd0d352f12 Include messages.h for macro form_str in select extensions 2013-04-27 04:57:44 -05:00
Elizabeth Myers
a6adeaad20 Fix format string generation 2013-04-27 04:57:31 -05:00
William Pitcock
960833fed6 Merge pull request #20 from quora-wings/master
Makefile.in updated
2013-04-20 20:24:25 -07:00
Quora
4dda34a0aa Makefile.in updated 2013-04-20 20:18:51 -07:00
Elizabeth Myers
be8f778945 Remove last vestige of halfops from this module.
How this was in here for this long is well beyond me. This must be old
hybrid code or something.
2013-04-20 21:23:27 -05:00
Quora
cec9e96f75 Removed redundant and buggy code that caused segmentation faults. Also deprecated by operspy support for LIST. Referencing commit Ponychat/shadowircd@162195279a 2013-04-20 13:59:27 -07:00
Elizabeth Myers
9d745dbd21 Implement kill-cancelling hook.
With this comes an example module to block the killing of services.

NOTE: this will not cancel remote kills. Those are still accepted, per
the TS 6 specification.
2013-04-20 01:07:55 -05:00
Jilles Tjoelker
e69375f3ac Cope with rb_crypt() returning NULL. 2013-02-02 00:54:32 +01:00
William Pitcock
4cbed3b849 extensions/m_roleplay: merge in darkmyst changes 2012-11-04 03:35:58 +00:00
William Pitcock
e5149d6169 Add module which restricts unauthenticated users from doing anything as channel op. 2012-11-01 06:48:40 +00:00