• Joined on 2024-03-28
9pfs approved countify/countify#30 2024-05-26 16:46:00 +00:00
Implement the /info endpoint
9pfs commented on pull request countify/countify#30 2024-05-26 16:41:55 +00:00
Implement the /info endpoint

Shouldn't this be await get_namespace_id?

9pfs suggested changes for countify/countify#30 2024-05-26 16:41:55 +00:00
Implement the /info endpoint
9pfs commented on pull request countify/countify#30 2024-05-26 16:36:48 +00:00
Implement the /info endpoint

Actually, by the countAPI spec, we're actually missing a value on keys:

Countapi ref:

/info/:namespace?/:key

Get information about a key.…

9pfs commented on pull request countify/countify#30 2024-05-26 16:34:43 +00:00
Implement the /info endpoint

Not sure, it'd probably require a db column that gets written to whenever a column is accessed + another one that has a "allowed time since access" thing or something. Just a ttl column probably…

9pfs commented on pull request countify/countify#30 2024-05-26 16:31:49 +00:00
Implement the /info endpoint

Actually, by the countAPI spec, we're actually missing a value on keys:

Countapi ref:

/info/:namespace?/:key

Get information about a key. Optionally specify the…

9pfs commented on pull request countify/countify#30 2024-05-26 16:31:04 +00:00
Implement the /info endpoint

Can we just not return the missing column? (Adding a column that is supposed to update on its own would be a nightmare)

9pfs commented on pull request countify/countify#30 2024-05-26 16:29:12 +00:00
Implement the /info endpoint

Shouldn't we be returning namespace, rather than namespace_id?

9pfs commented on pull request countify/countify#30 2024-05-26 16:28:53 +00:00
Implement the /info endpoint

Not sure, but it just seems like a bad idea to allow unauthenticated users to query everything in a db table

9pfs commented on pull request countify/countify#30 2024-05-26 16:28:00 +00:00
Implement the /info endpoint

Actually, by the countAPI spec, we're actually missing a value on keys:

Countapi ref:

/info/:namespace?/:key

Get information about a key. Optionally specify the namespace. …

9pfs commented on pull request countify/countify#30 2024-05-26 16:25:47 +00:00
Implement the /info endpoint

What if more things that we don't want to return are added later on, though?

9pfs commented on pull request countify/countify#30 2024-05-26 16:25:25 +00:00
Implement the /info endpoint

Not really, it'd probably just waste up to two queries on something avoidable

9pfs commented on pull request countify/countify#30 2024-05-26 16:22:33 +00:00
Implement the /info endpoint

Would it be possible to only query what's actually needed here?

9pfs commented on pull request countify/countify#30 2024-05-26 16:22:33 +00:00
Implement the /info endpoint

Why not validate ns_name and key here?

9pfs approved countify/countify#29 2024-05-26 16:14:03 +00:00
Implement the /set endpoint
9pfs suggested changes for countify/countify#29 2024-05-26 08:02:57 +00:00
Implement the /set endpoint
9pfs commented on pull request countify/countify#29 2024-05-26 08:02:57 +00:00
Implement the /set endpoint

Just checked

9pfs commented on pull request countify/countify#29 2024-05-26 08:02:57 +00:00
Implement the /set endpoint

Pretty sure this will always return false (also, true in the response from the db should be a boolean, rather than a string, iirc, and it'd be db_res[0].enable_reset).

9pfs commented on pull request countify/countify#29 2024-05-26 08:02:57 +00:00
Implement the /set endpoint

It'd be nice to somehow make counter_get optionally return the get_namespace_id response it gets to save a DB query, but that's probably not very important.

9pfs commented on pull request countify/countify#29 2024-05-26 08:02:57 +00:00
Implement the /set endpoint

Could something like this maybe be used? idk, I might be a bit tired right now.