Firepup650/FireBot
2
0
Fork 1
Code Issues 5 Pull requests Activity Actions

Actually handle large blobs of data properly #5

New issue
Closed
opened 2024-04-22 23:36:35 +00:00 by Firepup650 · 2 comments
Firepup650 commented 2024-04-22 23:36:35 +00:00
Owner
Copy link

I don't really do this, if a line doesn't end with a \r\n, then we should expect another line from the server, and add it to the current one, it could be an issue in rare cases if a message gets cut off perfectly, and ends up with, say, ERROR :Closing on the next read. Theoretically, should never be an issue, but it's a safety precaution that should be taken.

I don't really do this, if a line doesn't end with a \r\n, then we should expect another line from the server, and add it to the current one, it could be an issue in rare cases if a message gets cut off perfectly, and ends up with, say, `ERROR :Closing` on the next read. Theoretically, should never be an issue, but it's a safety precaution that should be taken.
Firepup650 added the
Priority
High
Kind/Enhancement
 labels 2024-04-22 23:37:12 +00:00
Firepup650 added
Priority
Low
 and removed
Priority
High
 labels 2024-04-23 02:11:55 +00:00
Firepup650 commented 2024-04-23 02:12:29 +00:00
Author
Owner
Copy link

Changed to low priority, since this is a rare edge case, usually only happens when connecting to the server, when it's mostly safe to ignore.

Changed to low priority, since this is a rare edge case, usually only happens when connecting to the server, when it's _mostly_ safe to ignore.
Firepup650 commented 2024-05-19 03:53:34 +00:00
Author
Owner
Copy link

Resolved by 49aa61417a

Resolved by 49aa61417ab4c3524f931cd1cdce063e1b6673c5
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
No results found.
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Priority
Zero
There is no priority on this change

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Priority
Zero
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Firepup650/FireBot#5
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?