Firepup650/FireBot
2
0
Fork 1
Code Issues 5 Pull requests Activity Actions

Avoid spamming #firemc #6

Closed
9pfs wants to merge 14 commits from 9pfs/FireBot:dont-spam-firemc into master
pull from: 9pfs/FireBot:dont-spam-firemc
merge into: Firepup650:master
Conversation 21 Commits 14 Files changed 3 +2 -7
2 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d2d0b47131 - Show all commits

2
bot.py
View file

@ -270,7 +270,7 @@ class bot(bare.bot):
tdict = {}
for thread in self.threads:
tdict[thread] = timers.data[thread]
if thread in ["radio"]:
if tdict[thread]["passInstance"]:
Firepup650 marked this conversation as resolved Outdated
Firepup650 commented 2024-05-01 01:03:14 +00:00
Outdated
Review
Copy link

Critical change, needs to be un-reverted

Critical change, needs to be un-reverted
9pfs marked this conversation as resolved Outdated
Firepup650 commented 2024-05-01 01:09:01 +00:00
Outdated
Review
Copy link

This needs to be indented another layer

This needs to be indented another layer
9pfs marked this conversation as resolved Outdated
Firepup650 commented 2024-05-01 01:13:47 +00:00
Outdated
Review
Copy link

We CANNOT use a tab here, this will crash the bot. It absolutely must be 4 spaces.

We CANNOT use a tab here, this will crash the bot. It absolutely must be 4 spaces.
9pfs commented 2024-05-01 01:15:12 +00:00
Outdated
Review
Copy link

Uh, what? I thought that WAS 4 spaces!

Uh, what? I thought that WAS 4 spaces!
😕 1
tdict[thread]["args"] = [self]
tMgr = Thread(target=timers.threadManager, args=(tdict,))
tMgr.daemon = True

7
timers.py
View file

@ -112,11 +112,6 @@ def radio(instance: bare.bot) -> NoReturn:
instance.log("Thread while loop broken", "FATAL")
exit(1)
def mcDown(instance: bare.bot) -> None:
instance.sendraw("TOPIC #firemc :FireMC Relay channel (offline)")
data: dict[str, dict[str, Any]] = {
"radio": {"noWrap": True, "func": radio, "args": []},
"mc-down": {"noWrap": False, "func": mcDown, "args": [], "interval": 60, "ignoreErrors": True}
Firepup650 marked this conversation as resolved Outdated
Firepup650 commented 2024-05-01 01:03:37 +00:00
Outdated
Review
Copy link

related to my other commit, this needs to use the new passInstance param.

related to my other commit, this needs to use the new `passInstance` param.
"radio": {"noWrap": True, "func": radio, "args": []}
Firepup650 marked this conversation as resolved Outdated
Firepup650 commented 2024-05-01 01:08:57 +00:00
Outdated
Review
Copy link

radio needs to use "passInstance": True, not "args": []

`radio` needs to use `"passInstance": True`, not `"args": []`
}