Refactor hook kwargs to be stored as a list of tuples to support key duplicates

closes #108
This commit is contained in:
jesopo 2019-07-28 12:35:04 +01:00
parent 047a21629f
commit 25b507e80c
3 changed files with 30 additions and 14 deletions

View file

@ -363,11 +363,7 @@ class Module(ModuleManager.BaseModule):
def _get_usage(self, hook, command, command_prefix=""): def _get_usage(self, hook, command, command_prefix=""):
command = "%s%s" % (command_prefix, command) command = "%s%s" % (command_prefix, command)
usage = hook.get_kwarg("usage", None) usages = hook.get_kwargs("usage")
if usage:
usages = [usage]
else:
usages = hook.docstring.var_items.get("usage", None)
if usages: if usages:
return " | ".join( return " | ".join(

View file

@ -29,23 +29,40 @@ class Event(object):
class EventHook(object): class EventHook(object):
def __init__(self, event_name: str, func: CALLBACK_TYPE, def __init__(self, event_name: str, func: CALLBACK_TYPE,
context: typing.Optional[str], priority: int, kwargs: dict): context: typing.Optional[str], priority: int,
kwargs: typing.List[typing.Tuple[str, typing.Any]]):
self.event_name = event_name self.event_name = event_name
self.function = func self.function = func
self.context = context self.context = context
self.priority = priority self.priority = priority
self._kwargs = kwargs
self.docstring = utils.parse.docstring(func.__doc__ or "") self.docstring = utils.parse.docstring(func.__doc__ or "")
self._kwargs = {}
self._multi_kwargs = {}
for key, value in kwargs:
if key in self._multi_kwargs:
self._multi_kwargs[key].append(value)
elif key in self._kwargs:
self._multi_kwargs[key] = [self._kwargs.pop(key), value]
else:
self._kwargs[key] = value
def call(self, event: Event) -> typing.Any: def call(self, event: Event) -> typing.Any:
return self.function(event) return self.function(event)
def get_kwarg(self, name: str, default=None) -> typing.Any: def get_kwargs(self, key: str) -> typing.List[typing.Any]:
if name in self._kwargs: if key in self._kwargs:
return self._kwargs[name] return [self._kwargs[key]]
elif name in self.docstring.items: elif key in self._multi_kwargs:
return self.docstring.items[name] return self._multi_kwargs[key].copy()
return default elif key in self.docstring.var_items:
return self.docstring.var_items[name]
elif key in self.docstring.items:
return [self.docstring.items[name]]
return []
def get_kwarg(self, key: str, default: typing.Any=None) -> typing.Any:
print(self.get_kwargs(key))
return (self.get_kwargs(key) or [default])[0]
class Events(object): class Events(object):
def __init__(self, root: "EventRoot", path: typing.List[str], def __init__(self, root: "EventRoot", path: typing.List[str],
@ -71,6 +88,9 @@ class Events(object):
def hook(self, func: CALLBACK_TYPE, priority: int = DEFAULT_PRIORITY, def hook(self, func: CALLBACK_TYPE, priority: int = DEFAULT_PRIORITY,
**kwargs): **kwargs):
self._hook(func, priority, list(kwargs.items()))
def _hook(self, func: CALLBACK_TYPE, priority: int = DEFAULT_PRIORITY,
kwargs: typing.List[typing.Tuple[str, typing.Any]] = []):
self._root._hook(self._path, func, self._context, priority, kwargs) self._root._hook(self._path, func, self._context, priority, kwargs)
def call(self, **kwargs): def call(self, **kwargs):

View file

@ -213,7 +213,7 @@ class ModuleManager(object):
magic = utils.get_magic(attribute) magic = utils.get_magic(attribute)
for hook, kwargs in magic.get_hooks(): for hook, kwargs in magic.get_hooks():
context_events.on(hook).hook(attribute, **dict(kwargs)) context_events.on(hook)._hook(attribute, kwargs=kwargs)
# @utils.export() magic # @utils.export() magic
if utils.has_magic(module_object): if utils.has_magic(module_object):