Return empty string on successful github webhook handling, not True

This commit is contained in:
jesopo 2018-12-08 09:10:44 +00:00
parent 9bef4b7df1
commit 8cc1168589

View file

@ -43,7 +43,7 @@ class Module(ModuleManager.BaseModule):
github_event = event["headers"]["X-GitHub-Event"]
if github_event == "ping":
return True
return ""
full_name = data["repository"]["full_name"]
hooks = self.bot.database.channel_settings.find_by_setting(
@ -64,7 +64,7 @@ class Module(ModuleManager.BaseModule):
targets.append([server, channel])
if not targets:
return True if repo_hooked else None
return "" if repo_hooked else None
outputs = None
if github_event == "push":
@ -97,7 +97,7 @@ class Module(ModuleManager.BaseModule):
hide_prefix=channel.get_setting(
"github-hide-prefix", False))
return True
return ""
def _change_count(self, n, symbol, color):
return utils.irc.color("%s%d" % (symbol, n), color)+utils.irc.bold("")