From b75fc02c4bcd7de9fae804fd6969d4915ee4aa51 Mon Sep 17 00:00:00 2001 From: jesopo Date: Tue, 14 May 2019 11:01:31 +0100 Subject: [PATCH] Add comment to clarify why we ignore 1-letter-nicks in _prevent_highlight --- modules/github/__init__.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/github/__init__.py b/modules/github/__init__.py index 8d36fb6e..f447c43d 100644 --- a/modules/github/__init__.py +++ b/modules/github/__init__.py @@ -423,6 +423,8 @@ class Module(ModuleManager.BaseModule): def _prevent_highlight(self, server, channel, s): for user in channel.users: if len(user.nickname) == 1: + # if we don't ignore 1-letter nicknames, the below while loop + # will fire indefininitely. continue s_lower = server.irc_lower(s)