Firepup650/bitbot-3.11-fork
2
0
Fork 0
Code Issues Pull requests Activity Actions

Throw an exception when we detect a complex circular dependency

Browse source
This commit is contained in:
jesopo 2019-05-27 11:42:47 +01:00
parent 5b780672a8
commit ce3a0668c6
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/ModuleManager.py
View file

@ -24,6 +24,8 @@ class ModuleDependencyNotFulfilled(ModuleException):
% (module, dependency)) % (module, dependency))
self.module = module self.module = module
self.dependency = dependency self.dependency = dependency
class ModuleCircularDependency(ModuleException):
pass
class ModuleType(enum.Enum): class ModuleType(enum.Enum):
FILE = 0 FILE = 0
@ -266,9 +268,12 @@ class ModuleManager(object):
self.log.warn( self.log.warn(
"Circular dependencies detected: %s<->%s", "Circular dependencies detected: %s<->%s",
[name, dep_name]) [name, dep_name])
changed = True
# snap a circular dependence # snap a circular dependence
deps.remove(dep_name) deps.remove(dep_name)
definition_dependencies[dep_name].remove(name) definition_dependencies[dep_name].remove(name)
if not changed:
raise ModuleCircularDependency()
return [definition_names[name] for name in definitions_ordered] return [definition_names[name] for name in definitions_ordered]