Firepup650/bitbot-3.11-fork
2
0
Fork 0
Code Issues Pull requests Activity Actions

cache when a setting isn't set but don't cache "default" value

Browse source
This commit is contained in:
jesopo 2019-09-04 15:26:36 +01:00
parent 473c2723e7
commit d7ae182428
1 changed files with 5 additions and 3 deletions

8
src/IRCChannel.py
View file

@ -152,14 +152,16 @@ class Channel(IRCObject.Object):
def get_setting(self, setting: str, default: typing.Any=None def get_setting(self, setting: str, default: typing.Any=None
) -> typing.Any: ) -> typing.Any:
cache_key = self._setting_cache_key(setting) cache_key = self._setting_cache_key(setting)
value = None
if self.bot.cache.has_item(cache_key): if self.bot.cache.has_item(cache_key):
return self.bot.cache.get(cache_key) value = self.bot.cache.get(cache_key)
else:
value = self.bot.database.channel_settings.get(self.id, setting, None)
self._cache_setting(cache_key, value)
value = self.bot.database.channel_settings.get(self.id, setting, None)
if value == None: if value == None:
return default return default
else: else:
self._cache_setting(cache_key, value)
return value return value
def find_settings(self, pattern: str, default: typing.Any=[] def find_settings(self, pattern: str, default: typing.Any=[]