Firepup Sixfifty Firepup650 · he/him
  • Firepi
  • Joined on 2024-03-29
Firepup650 commented on pull request countify/countify#30 2024-05-26 16:44:01 +00:00
Implement the /info endpoint

Fixed

Firepup650 pushed to info-endpoint at countify/countify 2024-05-26 16:43:51 +00:00
f1e08c789e This should have been awaited.
Firepup650 commented on pull request countify/countify#30 2024-05-26 16:43:00 +00:00
Implement the /info endpoint

d'oh!

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:40:43 +00:00
Implement the /info endpoint

For now, I've set it to query the other columns, we need to do ttl later.

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:40:04 +00:00
Implement the /info endpoint

Validation is now done.

Firepup650 pushed to info-endpoint at countify/countify 2024-05-26 16:39:43 +00:00
6a1c444770 Small fixes
8985e25bac Unrelated, but verify the namespace and key are actual valid before making them
ad4652c874 Validate key and namespace names
Compare 3 commits »
Firepup650 commented on pull request countify/countify#30 2024-05-26 16:33:37 +00:00
Implement the /info endpoint

Actually, by the countAPI spec, we're actually missing a value on keys:

Countapi ref:

/info/:namespace?/:key

Get information about a key. Optionally…

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:32:01 +00:00
Implement the /info endpoint

How else are you planning on doing the expiries?

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:31:23 +00:00
Implement the /info endpoint

Shouldn't we be returning namespace, rather than namespace_id?

Oh yeah, I guess so. Will fix.

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:31:08 +00:00
Implement the /info endpoint

Actually, by the countAPI spec, we're actually missing a value on keys:

Countapi ref:

/info/:namespace?/:key

Get information about a key. Optionally specify the…

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:30:04 +00:00
Implement the /info endpoint

Can't really fix this until we add the missing column, it'll error if I do.

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:27:46 +00:00
Implement the /info endpoint

What else would we add to keys themselves? The expiry is supposed to be returned too actually (see below).

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:27:05 +00:00
Implement the /info endpoint

I'll throw the validation in I guess, just seems unnecessary.

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:26:28 +00:00
Implement the /info endpoint

Actually, by the countAPI spec, we're actually missing a value on keys:

Countapi ref:

/info/:namespace?/:key

Get information about a key. Optionally specify the namespace.

https…
Firepup650 commented on pull request countify/countify#30 2024-05-26 16:24:10 +00:00
Implement the /info endpoint

I guess we could, but won't SQL end up doing that for us?

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:23:42 +00:00
Implement the /info endpoint

/info returns everything, so everything is needed here.

Firepup650 opened issue countify/countify#31 2024-05-26 16:20:27 +00:00
get_counter_value should be renamed to counter_get for consistency
Firepup650 commented on pull request countify/countify#30 2024-05-26 16:16:58 +00:00
Implement the /info endpoint

Fixes #10

Firepup650 pushed to main at countify/countify 2024-05-26 16:16:06 +00:00
4ace687121 Change failed to be true regardless of when it fails, asjust logic accordingly
9f62ef78d3 Slight optimization
d1aa74a14e Make get_counter_value optionally return the nsid.
fda599c32a Un-wrap this sql call
51c684a416 Revert "Un-wrap this sql call"
Compare 13 commits »
Firepup650 closed issue countify/countify#8 2024-05-26 16:16:05 +00:00
/set implementation