Firepup Sixfifty Firepup650 · he/him
  • Firepi
  • Joined on 2024-03-29
Firepup650 opened issue countify/countify#33 2024-05-26 18:47:20 +00:00
Remaining issues with countapi compatibility
Firepup650 commented on pull request countify/countify#32 2024-05-26 18:30:11 +00:00
Implement /stats endpoint

Could this please just be merged as-is?

Sure. I'm PR'ing the Query in next though if you don't add it.

I may reject a PR in that case, not sure

_Reminds you that the…

Firepup650 approved countify/countify#32 2024-05-26 18:28:30 +00:00
Implement /stats endpoint
Firepup650 commented on pull request countify/countify#32 2024-05-26 18:28:23 +00:00
Implement /stats endpoint

Could this please just be merged as-is?

Sure. I'm PR'ing the Query in next though if you don't add it.

Firepup650 commented on pull request countify/countify#32 2024-05-26 17:44:31 +00:00
Implement /stats endpoint

Why not request a count of rows in the keys table on boot? https://stackoverflow.com/a/28916930

Doesn't that not necessarily…

Firepup650 commented on pull request countify/countify#32 2024-05-26 17:38:51 +00:00
Implement /stats endpoint

Why not request a count of rows in the keys table on boot? https://stackoverflow.com/a/28916930

Doesn't that not necessarily reflect how many have…

Firepup650 commented on pull request countify/countify#32 2024-05-26 17:34:33 +00:00
Implement /stats endpoint

Why not request a count of rows in the keys table on boot? https://stackoverflow.com/a/28916930

Doesn't that not necessarily reflect how many have actually been…

Firepup650 commented on pull request countify/countify#32 2024-05-26 17:34:04 +00:00
Implement /stats endpoint

https://stackoverflow.com/a/7945274

This seems like a much faster query actually:

SELECT (CASE WHEN c.reltuples < 0 THEN NULL
             WHEN c.relpages = 0 THEN float8 '0'
          …
Firepup650 commented on pull request countify/countify#32 2024-05-26 17:32:11 +00:00
Implement /stats endpoint

Why not request a count of rows in the keys table on boot? https://stackoverflow.com/a/28916930

Doesn't that not necessarily reflect how many have actually been created?

It's…

Firepup650 suggested changes for countify/countify#32 2024-05-26 17:22:36 +00:00
Implement /stats endpoint

Why not request a count of rows in the keys table on boot?

Firepup650 pushed to fp-edits at countify/countify 2024-05-26 16:47:58 +00:00
f1e08c789e This should have been awaited.
6a1c444770 Small fixes
8985e25bac Unrelated, but verify the namespace and key are actual valid before making them
ad4652c874 Validate key and namespace names
46ff56f0b4 Implement /info endpoint
Compare 5 commits »
Firepup650 deleted branch info-endpoint from countify/countify 2024-05-26 16:47:07 +00:00
Firepup650 pushed to main at countify/countify 2024-05-26 16:46:58 +00:00
f1e08c789e This should have been awaited.
6a1c444770 Small fixes
8985e25bac Unrelated, but verify the namespace and key are actual valid before making them
ad4652c874 Validate key and namespace names
46ff56f0b4 Implement /info endpoint
Compare 5 commits »
Firepup650 closed issue countify/countify#10 2024-05-26 16:46:57 +00:00
/info endpoint
Firepup650 merged pull request countify/countify#30 2024-05-26 16:46:57 +00:00
Implement the /info endpoint
Firepup650 commented on pull request countify/countify#30 2024-05-26 16:44:01 +00:00
Implement the /info endpoint

Fixed

Firepup650 pushed to info-endpoint at countify/countify 2024-05-26 16:43:51 +00:00
f1e08c789e This should have been awaited.
Firepup650 commented on pull request countify/countify#30 2024-05-26 16:43:00 +00:00
Implement the /info endpoint

d'oh!

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:40:43 +00:00
Implement the /info endpoint

For now, I've set it to query the other columns, we need to do ttl later.

Firepup650 commented on pull request countify/countify#30 2024-05-26 16:40:04 +00:00
Implement the /info endpoint

Validation is now done.